Review Request 115233: libKPeople: Draft version of SkypeDataSource

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115233/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 6:29 p.m.)


Review request for Telepathy, David Edmundson and Martin Klapetek.


Changes
-------

Plugin is still support only single-account mode!

Removed hardcoded database filename.
Implemented option "Account" for "SkypePlugin" group in "kpeoplerc" config file.
Handled situation when account is not setted or db can't be opened.

Contacts loading delayed (moved out from constructor) in SkypeAllContactsMonitor.

Plugin rebased on latest KPeople code.
Added emitInitialFetchComplete().

Code refactored.

(*Bold font turned on*) Code is not proposed to be merged as is! (*Bold font turned off*)

P.S.: Use line 224 to set your account name.


Repository: libkpeople


Description
-------

Initial version of SkypeDataSource plugin.
UI for account selection is not yet implemented, so in current state plugin doesn't works. (You can edit skypedatasource.cpp:67 and manualy set your account)


Diffs (updated)
-----

  src/plugins/CMakeLists.txt 3633676 
  src/plugins/skype/CMakeLists.txt PRE-CREATION 
  src/plugins/skype/skype_kpeople_plugin.desktop PRE-CREATION 
  src/plugins/skype/skypedatasource.h PRE-CREATION 
  src/plugins/skype/skypedatasource.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115233/diff/


Testing
-------


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140225/874aec85/attachment.html>