<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115233/">https://git.reviewboard.kde.org/r/115233/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Martin Klapetek.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 6:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Plugin is still support only single-account mode!
Removed hardcoded database filename.
Implemented option "Account" for "SkypePlugin" group in "kpeoplerc" config file.
Handled situation when account is not setted or db can't be opened.
Contacts loading delayed (moved out from constructor) in SkypeAllContactsMonitor.
Plugin rebased on latest KPeople code.
Added emitInitialFetchComplete().
Code refactored.
(*Bold font turned on*) Code is not proposed to be merged as is! (*Bold font turned off*)
P.S.: Use line 224 to set your account name.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial version of SkypeDataSource plugin.
UI for account selection is not yet implemented, so in current state plugin doesn't works. (You can edit skypedatasource.cpp:67 and manualy set your account)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/CMakeLists.txt <span style="color: grey">(3633676)</span></li>
<li>src/plugins/skype/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/skype/skype_kpeople_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/skype/skypedatasource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/skype/skypedatasource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>