Review Request 115842: Contact info button in Actions menu for regular chat

Jan Stourac stourac.jan at gmail.com
Mon Feb 17 23:24:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115842/
-----------------------------------------------------------

(Updated Feb. 18, 2014, 12:24 a.m.)


Review request for Telepathy.


Changes
-------

leak fix


Repository: ktp-text-ui


Description
-------

button which shows info dialog about active contact in chat

works only for regular chat (no group), due to problem with real user ID in group chat

is compatible with kpeople


Diffs (updated)
-----

  CMakeLists.txt 27f2dcd 
  app/CMakeLists.txt 39f009d 
  app/chat-window.h 793ac55 
  app/chat-window.cpp 5180c02 
  app/chatwindow.rc 0d0f6a8 

Diff: https://git.reviewboard.kde.org/r/115842/diff/


Testing
-------

compilation and tests OK with and without kpeople support


Thanks,

Jan Stourac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/ac73f2f3/attachment.html>


More information about the KDE-Telepathy mailing list