Review Request 115842: Contact info button in Actions menu for regular chat

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115842/#review50111
-----------------------------------------------------------



app/chat-window.cpp
<https://git.reviewboard.kde.org/r/115842/#comment35222>

    



app/chat-window.cpp
<https://git.reviewboard.kde.org/r/115842/#comment35223>

    These both leak.
    


- David Edmundson


On Feb. 17, 2014, 8:11 p.m., Jan Stourac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115842/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 8:11 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> button which shows info dialog about active contact in chat
> 
> works only for regular chat (no group), due to problem with real user ID in group chat
> 
> is compatible with kpeople
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 83533c4 
>   app/CMakeLists.txt 39f009d 
>   app/chat-window.h 793ac55 
>   app/chat-window.cpp 5180c02 
>   app/chatwindow.rc 0d0f6a8 
> 
> Diff: https://git.reviewboard.kde.org/r/115842/diff/
> 
> 
> Testing
> -------
> 
> compilation and tests OK with and without kpeople support
> 
> 
> Thanks,
> 
> Jan Stourac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/058e2ff2/attachment.html>