Review Request 115833: Emit modelInitialized() after all AllContactsMonitors finished initial contacts fetch

Commit Hook null at kde.org
Mon Feb 17 17:20:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115833/#review50073
-----------------------------------------------------------


This review has been submitted with commit 629cdf97f90cc6538304710d0b9a8994e0fdbc6f by Dan Vrátil to branch master.

- Commit Hook


On Feb. 17, 2014, 4:09 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115833/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 4:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 331146
>     http://bugs.kde.org/show_bug.cgi?id=331146
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> As discussed on IRC, each AllContactsMonitor emits initialFetchComplete() signal once it finished fetching all contacts after start. When all monitors from all DataSources have emitted the signal, PersonsModel will emit modelInitialized() signal.
> 
> Patch for KTpAllContacts DataSource will follow.
> 
> 
> Diffs
> -----
> 
>   src/allcontactsmonitor.h be13fbd 
>   src/allcontactsmonitor.cpp ce01f52 
>   src/personsmodel.h 4b087be 
>   src/personsmodel.cpp 47e3932 
>   src/plugins/akonadi/akonadidatasource.cpp 7625e2b 
> 
> Diff: https://git.reviewboard.kde.org/r/115833/diff/
> 
> 
> Testing
> -------
> 
> Fixes bug 331146.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/533e7f4c/attachment-0001.html>


More information about the KDE-Telepathy mailing list