Review Request 115833: Emit modelInitialized() after all AllContactsMonitors finished initial contacts fetch

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115833/#review50063
-----------------------------------------------------------

Ship it!


Wait till the KTp patch is ready before pushing this.


src/allcontactsmonitor.cpp
<https://git.reviewboard.kde.org/r/115833/#comment35165>

    It's clearly not unused now !
    
    but thanks :)



src/personsmodel.cpp
<https://git.reviewboard.kde.org/r/115833/#comment35166>

    we can/should move the call to 
    
    onContactsFetched() here, just before the q_emit.


- David Edmundson


On Feb. 17, 2014, 4:09 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115833/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 4:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 331146
>     http://bugs.kde.org/show_bug.cgi?id=331146
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> As discussed on IRC, each AllContactsMonitor emits initialFetchComplete() signal once it finished fetching all contacts after start. When all monitors from all DataSources have emitted the signal, PersonsModel will emit modelInitialized() signal.
> 
> Patch for KTpAllContacts DataSource will follow.
> 
> 
> Diffs
> -----
> 
>   src/allcontactsmonitor.h be13fbd 
>   src/allcontactsmonitor.cpp ce01f52 
>   src/personsmodel.h 4b087be 
>   src/personsmodel.cpp 47e3932 
>   src/plugins/akonadi/akonadidatasource.cpp 7625e2b 
> 
> Diff: https://git.reviewboard.kde.org/r/115833/diff/
> 
> 
> Testing
> -------
> 
> Fixes bug 331146.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/47b775fb/attachment.html>