Review Request 119955: Port auth handler SASL operation from KWallet to Accounts SSO

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119955/#review65372
-----------------------------------------------------------



sasl-auth-op.cpp
<https://git.reviewboard.kde.org/r/119955/#comment45683>

    we can't have an #ifdef HAVE_SSO over here, and then explicitly use it somewhere else.



sasl-auth-op.cpp
<https://git.reviewboard.kde.org/r/119955/#comment45682>

    here we check m_accountStorageId is valid, and maps Tp accounts to SSO.
    
    I don't see why your new code has a config file, and if it is needed then this code here is super wrong.


- David Edmundson


On Aug. 27, 2014, 2:09 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119955/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 2:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.
> 
> 
> Diffs
> -----
> 
>   sasl-auth-op.cpp c54d662 
>   x-telepathy-password-auth-operation.cpp f999748 
>   x-telepathy-password-auth-operation.h 65d6462 
>   x-telepathy-password-prompt.h fa8c1ce 
>   x-telepathy-password-prompt.cpp b53b1f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119955/diff/
> 
> 
> Testing
> -------
> 
> I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140827/65b83858/attachment.html>