Review Request 119955: Port auth handler SASL operation from KWallet to Accounts SSO

[Martin Klapetek]

> On Aug. 27, 2014, 4:25 p.m., David Edmundson wrote:
> > we already have specialist SSO plugins, where do they fit in?

They are OAuth based ones, this is a password based one. Basically KAccounts offers several (plugin-based) auth mechanisms - oauth and password are two. With the oauth plugins (like for google, facebook and twitter and etc) the user authenticates on the website, which will return the oauth tokens which are then stored. Additionally to those tokens, we also store the entered username & password. So for Google & Facebook, we have the option to use the oauth tokens even for signing in with KTp (those are those SSO plugins you have in mind). But for all the other accounts, that do not support oauth, we still need the password based auth.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119955/#review65368
-----------------------------------------------------------


On Aug. 27, 2014, 4:09 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119955/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 4:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> This makes auth handler look into the SSO storage for credentials. If the password is wrong, the user is prompted for new one and if he wants to save that password, the password is overriden in SSO.
> 
> 
> Diffs
> -----
> 
>   sasl-auth-op.cpp c54d662 
>   x-telepathy-password-auth-operation.cpp f999748 
>   x-telepathy-password-auth-operation.h 65d6462 
>   x-telepathy-password-prompt.h fa8c1ce 
>   x-telepathy-password-prompt.cpp b53b1f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119955/diff/
> 
> 
> Testing
> -------
> 
> I created an account using KAccounts with both good and wrong password. With good password it just authenticates as expected, with wrong password I get a password prompt, entering a correct password makes it override the stored one and any further login does not spawn the password prompt again.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140827/c79efc18/attachment.html>