Review Request 119931: [frameworks] Add KAccounts integration plugin

[Martin Klapetek]

> On Aug. 26, 2014, 12:51 p.m., David Edmundson wrote:
> > do we really need a 3rd kded module? Can't this be a tiny dbus-activated app?

KAccounts have a kded module which reacts on created/removed accounts, this does not add any other ktp kded module, but a plugin for the KAccounts kded module.


> On Aug. 26, 2014, 12:51 p.m., David Edmundson wrote:
> > kaccounts/kaccounts-ktp-plugin.cpp, line 54
> > <https://git.reviewboard.kde.org/r/119931/diff/2/?file=307658#file307658line54>
> >
> >     is this not the entire point?

Not for now. The accounts are created using the plugin from ktp-accounts-kcm, but now they need to be removed too.

(why do I even always bother writing the description... :P)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119931/#review65266
-----------------------------------------------------------


On Aug. 26, 2014, 12:36 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119931/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 12:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> KAccounts have a kded module monitoring for accounts-sso accounts changes, this adds the ktp plugin for it, currently KAccounts supports only direct KTp accounts (as opposed to "Google Accounts" with chat service, for example) and the accounts are created using a plugin from accounts-kcm (which uses the UI plugins from it), we still need to remove the KTp accounts whenever it is removed from KAccounts
> 
> 
> Diffs
> -----
> 
>   kaccounts/kaccounts-ktp-plugin.cpp PRE-CREATION 
>   CMakeLists.txt 17dc6d8 
>   kaccounts/CMakeLists.txt PRE-CREATION 
>   kaccounts/kaccounts-ktp-plugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119931/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140826/affbd3ee/attachment.html>