Review Request 119931: [frameworks] Add KAccounts integration plugin

David Edmundson david at davidedmundson.co.uk
Tue Aug 26 10:51:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119931/#review65266
-----------------------------------------------------------


do we really need a 3rd kded module? Can't this be a tiny dbus-activated app?


kaccounts/kaccounts-ktp-plugin.cpp
<https://git.reviewboard.kde.org/r/119931/#comment45610>

    is this not the entire point?


- David Edmundson


On Aug. 26, 2014, 10:36 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119931/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 10:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> KAccounts have a kded module monitoring for accounts-sso accounts changes, this adds the ktp plugin for it, currently KAccounts supports only direct KTp accounts (as opposed to "Google Accounts" with chat service, for example) and the accounts are created using a plugin from accounts-kcm (which uses the UI plugins from it), we still need to remove the KTp accounts whenever it is removed from KAccounts
> 
> 
> Diffs
> -----
> 
>   kaccounts/kaccounts-ktp-plugin.cpp PRE-CREATION 
>   CMakeLists.txt 17dc6d8 
>   kaccounts/CMakeLists.txt PRE-CREATION 
>   kaccounts/kaccounts-ktp-plugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119931/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140826/52d5511f/attachment.html>


More information about the KDE-Telepathy mailing list