Review Request 119735: Added Useful Person Customs and Images for delegates

[Nilesh Suthar]

> On Aug. 25, 2014, 3:38 p.m., Martin Klapetek wrote:
> > src/persondata.cpp, line 51
> > <https://git.reviewboard.kde.org/r/119735/diff/1/?file=304002#file304002line51>
> >
> >     This should not happen; is your akonadi running correctly?

look at line 121 
http://quickgit.kde.org/?p=libkpeople.git&a=blob&h=2a7ef4e9b2aa416e48339e40cc88d7f1b1f15599&hb=95dd80093a8e79644fc4a871458c5ffb61232e1b&f=src%2Fpersonmanager.cpp
it should have returned contactId instead of QString(). As Kpeople:// links occurs only contacts which are merged so mostly it was returning null as my all the contacts were unmerged. It returning null from here so I added empty check in line 171 of metacontact.cpp


> On Aug. 25, 2014, 3:38 p.m., Martin Klapetek wrote:
> > src/metacontact.cpp, lines 171-173
> > <https://git.reviewboard.kde.org/r/119735/diff/1/?file=304001#file304001line171>
> >
> >     Actually you shouldn't need this at all, this should already be set on the contact itself (d->contacts().first()), which is the KABC::Addressee that will get used for the person if there's only one contact

Will it be set by akonadidatasource plugin?


- Nilesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119735/#review65179
-----------------------------------------------------------


On Aug. 12, 2014, 7:46 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119735/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 7:46 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Added person custom need in the application as helper and images for person list view delegates
> 
> 
> Diffs
> -----
> 
>   pixmaps/CMakeLists.txt 4dd08ba 
>   pixmaps/facebook-icon.png PRE-CREATION 
>   pixmaps/google-icon.png PRE-CREATION 
>   src/metacontact.cpp e9bfb04 
>   src/persondata.cpp e6eed9c 
>   src/plugins/akonadi/akonadidatasource.cpp 41d9803 
> 
> Diff: https://git.reviewboard.kde.org/r/119735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140825/fad4ba16/attachment.html>