Review Request 119735: Added Useful Person Customs and Images for delegates

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119735/#review65179
-----------------------------------------------------------



src/metacontact.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45535>

    if( --> if (
    
    ...ty()&& --> ...ty() &&
    
    also I don't think you need to be checking for "id" being empty, just set it



src/metacontact.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45538>

    Actually you shouldn't need this at all, this should already be set on the contact itself (d->contacts().first()), which is the KABC::Addressee that will get used for the person if there's only one contact



src/metacontact.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45536>

    indent on 4 spaces (also the end of the line has additional space, remove it)



src/metacontact.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45537>

    remove the empty spaces here (but leave the empty line)



src/metacontact.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45539>

    4 spaces indent



src/persondata.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45540>

    This should not happen; is your akonadi running correctly?



src/persondata.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45541>

    I don't think you can do this, it presumably breaks other things



src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45542>

    space after ,
    
    the collection should be const & (like the Item is)



src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45543>

    space after , not needed here, read http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/ for why ;)



src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45544>

    Why are you not modifying the contact directly? Just remove the const in the line above
    
    (obviously if you need to change things in an object, then it cannot be const, so don't be afraid to remove it ;)



src/plugins/akonadi/akonadidatasource.cpp
<https://git.reviewboard.kde.org/r/119735/#comment45545>

    spaces between args


- Martin Klapetek


On Aug. 12, 2014, 4:16 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119735/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 4:16 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Added person custom need in the application as helper and images for person list view delegates
> 
> 
> Diffs
> -----
> 
>   pixmaps/CMakeLists.txt 4dd08ba 
>   pixmaps/facebook-icon.png PRE-CREATION 
>   pixmaps/google-icon.png PRE-CREATION 
>   src/metacontact.cpp e9bfb04 
>   src/persondata.cpp e6eed9c 
>   src/plugins/akonadi/akonadidatasource.cpp 41d9803 
> 
> Diff: https://git.reviewboard.kde.org/r/119735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140825/c14fc2ae/attachment-0001.html>