Review Request 117671: Add a filter to hide empty groups as well as fix expansion of metacontacts
David Edmundson
david at davidedmundson.co.uk
Tue Apr 22 13:51:11 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117671/#review56184
-----------------------------------------------------------
Somehow this breaks sorting.
Not quite sure how, but I hate it.
- David Edmundson
On April 20, 2014, 10:36 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117671/
> -----------------------------------------------------------
>
> (Updated April 20, 2014, 10:36 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-contact-list
>
>
> Description
> -------
>
> Add a filter to hide empty groups as well as fix expansion of metacontacts
>
> Remove our rather bad style workaroudn to expand groups with only one
> entry, and instead just filter them out at the model level.
>
>
> Diffs
> -----
>
> CMakeLists.txt 09061bf
> abstract-contact-delegate.cpp a92cc4e
> contact-list-widget.cpp 74ad75b
> contact-list-widget_p.h e4a5eb3
> row-filter.h PRE-CREATION
> row-filter.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140422/b6f8e72d/attachment.html>
More information about the KDE-Telepathy
mailing list