Review Request 117671: Add a filter to hide empty groups as well as fix expansion of metacontacts

[David Edmundson]

> On April 22, 2014, 7:42 a.m., Martin Klapetek wrote:
> > contact-list-widget.cpp, lines 74-91
> > <https://git.reviewboard.kde.org/r/117671/diff/1/?file=267364#file267364line74>
> >
> >     How does the list look without this?

The same. This was a hack to hide the expanding icon on items with only one child.
The model filter means they never show.


> On April 22, 2014, 7:42 a.m., Martin Klapetek wrote:
> > row-filter.h, line 24
> > <https://git.reviewboard.kde.org/r/117671/diff/1/?file=267366#file267366line24>
> >
> >     Wouldn't just "QSortFilterProxyModel" work?

Yeah, autocomplete :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117671/#review56160
-----------------------------------------------------------


On April 20, 2014, 10:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117671/
> -----------------------------------------------------------
> 
> (Updated April 20, 2014, 10:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Add a filter to hide empty groups as well as fix expansion of metacontacts
>     
> Remove our rather bad style workaroudn to expand groups with only one
> entry, and instead just filter them out at the model level.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09061bf 
>   abstract-contact-delegate.cpp a92cc4e 
>   contact-list-widget.cpp 74ad75b 
>   contact-list-widget_p.h e4a5eb3 
>   row-filter.h PRE-CREATION 
>   row-filter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117671/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140422/1f87df60/attachment-0001.html>