Review Request 117552: Fix %service% replacement in adium themes

Leon Handreke leonh at ndreke.de
Sun Apr 13 21:11:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117552/#review55670
-----------------------------------------------------------

Ship it!



config/appearance-config-tab.cpp
<https://git.reviewboard.kde.org/r/117552/#comment38752>

    Yeah, better add a note about the weird API here as well.



logviewer/message-view.cpp
<https://git.reviewboard.kde.org/r/117552/#comment38753>

    Here as well.


- Leon Handreke


On April 13, 2014, 7:52 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117552/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 7:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Fix %service% replacement in adium themes
> 
> The service is set just once for the chat instead of for every message
> 
> Also set service icon in logviewer and demo chat
> 
> 
> Diffs
> -----
> 
>   config/appearance-config-tab.cpp 5f90c29120968e202e571d3350980691e98d5270 
>   lib/adium-theme-header-info.h 177d699c5e9aa9389c0b7ea8312ebfc04a8294dc 
>   lib/adium-theme-header-info.cpp 3dfa249fc13558822b4991c0881cbca70240f709 
>   lib/adium-theme-message-info.h 35ead2368331008deb2b5a8bc303236cd9d92893 
>   lib/adium-theme-message-info.cpp 7726fd2c6be4c59bf420a9f1a0d814466a23b1f0 
>   lib/adium-theme-view.h 2628ba896f510f489b98b741ea951aec0289b981 
>   lib/adium-theme-view.cpp 72306a65d43a5c83a23ec0139d56071a9b068d77 
>   lib/chat-widget.cpp 368274286a193f877cfbe7a4314fafbaa9b9e3c2 
>   logviewer/message-view.cpp ba69532390893bd0d16e65d84348f1373687effb 
> 
> Diff: https://git.reviewboard.kde.org/r/117552/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140413/d9a99075/attachment.html>


More information about the KDE-Telepathy mailing list