<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117552/">https://git.reviewboard.kde.org/r/117552/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/117552/diff/4/?file=265358#file265358line46" style="color: black; font-weight: bold; text-decoration: underline;">config/appearance-config-tab.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">AppearanceConfigTab::AppearanceConfigTab(QWidget *parent, TabMode mode)</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">m_demoChatHeader</span><span class="p">.</span><span class="n">setServiceIconPath</span><span class="p">(</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">global</span><span class="p">()</span><span class="o">-></span><span class="n">iconPath</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"im-jabber"</span><span class="p">),</span> <span class="o">-</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">SizeMedium</span><span class="p">));</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, better add a note about the weird API here as well.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/117552/diff/4/?file=265366#file265366line130" style="color: black; font-weight: bold; text-decoration: underline;">logviewer/message-view.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MessageView::onEventsLoaded(KTp::PendingLoggerOperation *po)</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">headerInfo</span><span class="p">.</span><span class="n">setServiceIconPath</span><span class="p">(</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">global</span><span class="p">()</span><span class="o">-></span><span class="n">iconPath</span><span class="p">(</span><span class="n">m_account</span><span class="o">-></span><span class="n">iconName</span><span class="p">(),</span> <span class="o">-</span><span class="n">KIconLoader</span><span class="o">::</span><span class="n">SizeMedium</span><span class="p">));</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here as well.</pre>
</div>
<br />



<p>- Leon Handreke</p>


<br />
<p>On April 13th, 2014, 7:52 p.m. UTC, Daniele E. Domenichelli wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Daniele E. Domenichelli.</div>


<p style="color: grey;"><i>Updated April 13, 2014, 7:52 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix %service% replacement in adium themes

The service is set just once for the chat instead of for every message

Also set service icon in logviewer and demo chat</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>config/appearance-config-tab.cpp <span style="color: grey">(5f90c29120968e202e571d3350980691e98d5270)</span></li>

 <li>lib/adium-theme-header-info.h <span style="color: grey">(177d699c5e9aa9389c0b7ea8312ebfc04a8294dc)</span></li>

 <li>lib/adium-theme-header-info.cpp <span style="color: grey">(3dfa249fc13558822b4991c0881cbca70240f709)</span></li>

 <li>lib/adium-theme-message-info.h <span style="color: grey">(35ead2368331008deb2b5a8bc303236cd9d92893)</span></li>

 <li>lib/adium-theme-message-info.cpp <span style="color: grey">(7726fd2c6be4c59bf420a9f1a0d814466a23b1f0)</span></li>

 <li>lib/adium-theme-view.h <span style="color: grey">(2628ba896f510f489b98b741ea951aec0289b981)</span></li>

 <li>lib/adium-theme-view.cpp <span style="color: grey">(72306a65d43a5c83a23ec0139d56071a9b068d77)</span></li>

 <li>lib/chat-widget.cpp <span style="color: grey">(368274286a193f877cfbe7a4314fafbaa9b9e3c2)</span></li>

 <li>logviewer/message-view.cpp <span style="color: grey">(ba69532390893bd0d16e65d84348f1373687effb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117552/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>