Ktp-Image-Sharer library

[Ahmed Ibrahim Khalil]

Hi All,
I've applied all your suggestions and committed them to the repository. [1]

If there are any suggestions or issue, I'll be glad to solve them :)

Cheers

[1]
https://github.com/R4md4c/image-sharer/commit/b48a14e58415779f824d37afad069f44749e751a


On Mon, Apr 7, 2014 at 10:51 AM, Martin Klapetek
<martin.klapetek at gmail.com>wrote:

> Hey,
>
> On Mon, Apr 7, 2014 at 3:28 AM, Ahmed I. Khalil <
> ahmedibrahimkhali at gmail.com> wrote:
>
>> Hi,
>>
>> I've written this library to add this feature [1] to KTp.
>> The library could also be used or linked with other different KTp
>> components.
>>
>> You can find the library code on Github [2]
>>
>
> Damn good job :)
>
>
>>
>> I'd like someone from KTp development team(David maybe?) to take a
>> look at the code and tell me about any shortcomings about it.
>>
>
> Quickly looking over ShareProvider, the slot name "finishedContentData" is
> a weird naming, you can use "finishedContentReading" or
> "finishedFileReading" or something. Also you randomly mix the slots naming,
> we try to stick to one naming scheme like "onSomethingHappened",
> "finishedDoingSomething" or "onSomethingFinished", so you might watch that
> out.
>
> In imgur sharer you do "qDebug() << responseData;" -- which is perfectly
> fine for local debug, but watch out what you put in the final code as we
> don't want to make the output too noisy.
>
> Some documentation in the abstract sharer .h would be awesome.
>
> License - for libraries it's better to use LGPL (v2.1) rather than GPL.
>
> Thanks for working on this!
>
> Cheers
> --
> Martin Klapetek | KDE Developer
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140407/8500e204/attachment.html>