Review Request 112597: Add support for ktp-active to set user typing status

[Siddhartha Sahu]

> On Sept. 13, 2013, 5:51 p.m., David Edmundson wrote:
> > Very nice.
> > Good comments too

Both code and comments copied over from text-ui ^_^


> On Sept. 13, 2013, 5:51 p.m., David Edmundson wrote:
> > KTp/Declarative/conversation.cpp, line 165
> > <http://git.reviewboard.kde.org/r/112597/diff/3/?file=189254#file189254line165>
> >
> >     no point  having d->pausedStateTimer->start(5000) inside the if statement
> >     
> >     
> >

The first start (line 161) is a restart of the timer
the second one (line 165) is to start the timer on first updateTextChanged call


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112597/#review39959
-----------------------------------------------------------


On Sept. 13, 2013, 4:46 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112597/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 4:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added functions for setting user typing status
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversation.h 6f50709 
>   KTp/Declarative/conversation.cpp 8284d81 
> 
> Diff: http://git.reviewboard.kde.org/r/112597/diff/
> 
> 
> Testing
> -------
> 
> tested, works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130913/1aa91cd1/attachment.html>