Review Request 112597: Add support for ktp-active to set user typing status
David Edmundson
david at davidedmundson.co.uk
Fri Sep 13 12:21:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112597/#review39959
-----------------------------------------------------------
Ship it!
Very nice.
Good comments too
KTp/Declarative/conversation.cpp
<http://git.reviewboard.kde.org/r/112597/#comment29504>
no point having d->pausedStateTimer->start(5000) inside the if statement
- David Edmundson
On Sept. 13, 2013, 11:16 a.m., Siddhartha Sahu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112597/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 11:16 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Added functions for setting user typing status
>
>
> Diffs
> -----
>
> KTp/Declarative/conversation.h 6f50709
> KTp/Declarative/conversation.cpp 8284d81
>
> Diff: http://git.reviewboard.kde.org/r/112597/diff/
>
>
> Testing
> -------
>
> tested, works
>
>
> Thanks,
>
> Siddhartha Sahu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130913/1983adbd/attachment.html>
More information about the KDE-Telepathy
mailing list