Review Request 112658: Draw branches for contacts in KPeople mode
David Edmundson
david at davidedmundson.co.uk
Tue Sep 10 23:56:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/
-----------------------------------------------------------
(Updated Sept. 10, 2013, 11:56 p.m.)
Review request for Telepathy.
Changes
-------
Added "before" picture in case some n00b isn't running kpeople yet and wants to comment.
Description
-------
Draw branches for contacts in KPeople mode
To me it's a lot easier to use and navigate and doesn't look too bad.
Requires https://git.reviewboard.kde.org/r/112657/
Fixes 2 of the release blocking bugs.
(https://bugs.kde.org/show_bug.cgi?id=324602 and https://bugs.kde.org/show_bug.cgi?id=324300)
These could be solved in other ways, for me this patch is mostly about fixing the problem of double clicking expanding (not reported).
Diffs
-----
contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84
contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257
contact-list-widget_p.h 5baae8776702c9f0f8aa78584a04ef402dea1d61
Diff: http://git.reviewboard.kde.org/r/112658/diff/
Testing
-------
File Attachments (updated)
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
Just arrows, no lines.
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png
Before
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/fb1.png
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/bb021a32/attachment.html>
More information about the KDE-Telepathy
mailing list