Review Request 112658: Draw branches for contacts in KPeople mode

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/
-----------------------------------------------------------

(Updated Sept. 10, 2013, 11:49 p.m.)


Review request for Telepathy.


Changes
-------

This ended up being a bit of a mission.

Qt's drawBranches function is a mess, it was easy to make work, but not recolour on mouseover. I looked in Qt code and they use mouseMoveEvent to track it internally, but it's not exposed.

Anyway, came up with a new solution.


Description
-------

Draw branches for contacts in KPeople mode

To me it's a lot easier to use and navigate and doesn't look too bad.

Requires https://git.reviewboard.kde.org/r/112657/

Fixes 2 of the release blocking bugs.

(https://bugs.kde.org/show_bug.cgi?id=324602 and https://bugs.kde.org/show_bug.cgi?id=324300)
These could be solved in other ways, for me this patch is mostly about fixing the problem of double clicking expanding (not reported).


Diffs (updated)
-----

  contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84 
  contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257 
  contact-list-widget_p.h 5baae8776702c9f0f8aa78584a04ef402dea1d61 

Diff: http://git.reviewboard.kde.org/r/112658/diff/


Testing
-------


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
Just arrows, no lines.
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/804d7ca2/attachment.html>