Review Request 112427: Enable Merge Contact Dialog in kpeople mode

[David Edmundson]

> On Sept. 1, 2013, 7:22 p.m., Dan Vrátil wrote:
> > main-widget.cpp, line 64
> > <http://git.reviewboard.kde.org/r/112427/diff/1/?file=186083#file186083line64>
> >
> >     No nice header file?

There is not. I do not know why.
This is why Franck is on the review list :D


> On Sept. 1, 2013, 7:22 p.m., Dan Vrátil wrote:
> > main-widget.cpp, line 82
> > <http://git.reviewboard.kde.org/r/112427/diff/1/?file=186083#file186083line82>
> >
> >     This is unrelated to the review itself, but since you touched the code: why do we use "NULL" here? NULL is a C expression, we always use "0" in KTp (and KDE in general).

I have no idea. I copied the style.
I agree it's werid.

There's also not a lot of point making it a member variable except that
setupMenu and setupToolBar are different methods.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112427/#review39094
-----------------------------------------------------------


On Sept. 1, 2013, 1:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112427/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2013, 1:40 p.m.)
> 
> 
> Review request for Telepathy and Franck Arrecot.
> 
> 
> Description
> -------
> 
> Enable Merge Contact Dialog in kpeople mode
> 
> BUG: 324301
> 
> 
> Diffs
> -----
> 
>   main-widget.h 7ec22a03b21ad9f8bdd6fabef4b9445f805b6763 
>   main-widget.cpp e9129a71305ee226834bca496e9910bb55247860 
> 
> Diff: http://git.reviewboard.kde.org/r/112427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130901/949c201e/attachment.html>