Review Request 112427: Enable Merge Contact Dialog in kpeople mode

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112427/#review39094
-----------------------------------------------------------

Ship it!



main-widget.cpp
<http://git.reviewboard.kde.org/r/112427/#comment28834>

    No nice header file?



main-widget.cpp
<http://git.reviewboard.kde.org/r/112427/#comment28833>

    This is unrelated to the review itself, but since you touched the code: why do we use "NULL" here? NULL is a C expression, we always use "0" in KTp (and KDE in general).


- Dan Vrátil


On Sept. 1, 2013, 3:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112427/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2013, 3:40 p.m.)
> 
> 
> Review request for Telepathy and Franck Arrecot.
> 
> 
> Description
> -------
> 
> Enable Merge Contact Dialog in kpeople mode
> 
> BUG: 324301
> 
> 
> Diffs
> -----
> 
>   main-widget.h 7ec22a03b21ad9f8bdd6fabef4b9445f805b6763 
>   main-widget.cpp e9129a71305ee226834bca496e9910bb55247860 
> 
> Diff: http://git.reviewboard.kde.org/r/112427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130901/3c782158/attachment-0001.html>