Review Request 113214: Fix adiumxtra-protocol-handler to show notifications to confirm installation again

[Leon Handreke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113214/
-----------------------------------------------------------

(Updated Oct. 12, 2013, 6:11 p.m.)


Review request for Telepathy.


Changes
-------

Use setComponentData instead of introducing a new notifyrc to get this in for 0.7. Duplicating ktelepathyComponentData() in every file is kind of ugly, but this should be fixed in master very soon.


Bugs: 325903
    http://bugs.kde.org/show_bug.cgi?id=325903


Repository: ktp-text-ui


Description
-------

Don't install the Adium extra automatically but show a notification to confirm the installation (as was probably originally intended by the authors of the code).

Use a separate notifyrc file for adiumxtra-protocol-handler so that the notification types used as the UI for adiumxtra-protocol-handler don't have to show up in the notification configuration dialog for the ktelepathy component anymore.

Disable the KIO progress notification that results in a non-informative "Copying [Finished]" notification for the temporary file being created.


Diffs (updated)
-----

  adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp b80e99a9d7e96be3ccf8be84e63522c07a70c296 
  adiumxtra-protocol-handler/chat-style-installer.cpp 9676c96a11263eef61bb14041ab002d11706f1d6 
  adiumxtra-protocol-handler/emoticon-set-installer.cpp a2011a33d34fcf757e69f790f8255fdd5492695e 

Diff: http://git.reviewboard.kde.org/r/113214/diff/


Testing
-------

To test emoticon set installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/4207')
To test message style installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/7780')


Thanks,

Leon Handreke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131012/e09dd6fd/attachment-0001.html>