<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113214/">http://git.reviewboard.kde.org/r/113214/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Leon Handreke.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2013, 6:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use setComponentData instead of introducing a new notifyrc to get this in for 0.7. Duplicating ktelepathyComponentData() in every file is kind of ugly, but this should be fixed in master very soon.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325903">325903</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't install the Adium extra automatically but show a notification to confirm the installation (as was probably originally intended by the authors of the code).
Use a separate notifyrc file for adiumxtra-protocol-handler so that the notification types used as the UI for adiumxtra-protocol-handler don't have to show up in the notification configuration dialog for the ktelepathy component anymore.
Disable the KIO progress notification that results in a non-informative "Copying [Finished]" notification for the temporary file being created.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To test emoticon set installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/4207')
To test message style installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/7780')
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp <span style="color: grey">(b80e99a9d7e96be3ccf8be84e63522c07a70c296)</span></li>
<li>adiumxtra-protocol-handler/chat-style-installer.cpp <span style="color: grey">(9676c96a11263eef61bb14041ab002d11706f1d6)</span></li>
<li>adiumxtra-protocol-handler/emoticon-set-installer.cpp <span style="color: grey">(a2011a33d34fcf757e69f790f8255fdd5492695e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113214/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>