Review Request 113044: Make data in details widget selectable

Elias Probst mail at eliasprobst.eu
Wed Oct 2 11:00:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113044/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 11 a.m.)


Review request for Telepathy.


Changes
-------

As suggested by David Edmundson, I reverted the changes in personpresentationwidget.cpp.


Bugs: 325510
    http://bugs.kde.org/show_bug.cgi?id=325510


Repository: libkpeople


Description
-------

This patch makes all the data in the details widget (phone, email, …) selectable.

See also:
https://git.reviewboard.kde.org/r/113033/


Diffs (updated)
-----

  src/widgets/plugins/emaildetailswidget.cpp f775c5722c1cda2a79072be79189eb3918ba1ef5 
  src/widgets/plugins/phonedetailswidget.cpp 980976f6962cb9f8c0b2c63b6ea6be4e30c9780e 

Diff: http://git.reviewboard.kde.org/r/113044/diff/


Testing
-------

No testing done yet as I seem to have some kpeople issues, resulting in contacts always only showing their IM ID, but no further information.

Need someone else to test this patch (besides building, which it does just fine).


Thanks,

Elias Probst

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131002/a39d006e/attachment.html>


More information about the KDE-Telepathy mailing list