Review Request 113044: Make data in details widget selectable

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113044/#review41090
-----------------------------------------------------------

Ship it!


See comment, ship the other 2


src/widgets/plugins/personpresentationwidget.cpp
<http://git.reviewboard.kde.org/r/113044/#comment30160>

    I don't think we need these ones. This widget is only used by the MergeSuggestions widget which is a bit different.


- David Edmundson


On Oct. 1, 2013, 11:15 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113044/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2013, 11:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 325510
>     http://bugs.kde.org/show_bug.cgi?id=325510
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> This patch makes all the data in the details widget (phone, email, …) selectable.
> 
> See also:
> https://git.reviewboard.kde.org/r/113033/
> 
> 
> Diffs
> -----
> 
>   src/widgets/plugins/emaildetailswidget.cpp f775c5722c1cda2a79072be79189eb3918ba1ef5 
>   src/widgets/plugins/personpresentationwidget.cpp 474fcb48883d097582782126a5346ccd7340d830 
>   src/widgets/plugins/phonedetailswidget.cpp 980976f6962cb9f8c0b2c63b6ea6be4e30c9780e 
> 
> Diff: http://git.reviewboard.kde.org/r/113044/diff/
> 
> 
> Testing
> -------
> 
> No testing done yet as I seem to have some kpeople issues, resulting in contacts always only showing their IM ID, but no further information.
> 
> Need someone else to test this patch (besides building, which it does just fine).
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131001/c0bdb00e/attachment-0001.html>