Review Request 114218: KPeople: Fixed default avatar location.

Alexandr Akulich akulichalexander at gmail.com
Fri Nov 29 23:09:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114218/
-----------------------------------------------------------

(Updated Nov. 30, 2013, 5:09 a.m.)


Review request for Telepathy.


Changes
-------

Fix PersonDetailsView as well.


Repository: libkpeople


Description
-------

WIP. I'm not sure if I did it right.
There is same issue in PersonDetailsView::reload(). I think that it still should be ported to PersonsModel so didn't change it now.


Diffs (updated)
-----

  src/personsmodel.cpp 7c238c1 
  src/widgets/persondetailsview.cpp 788bfbb 

Diff: http://git.reviewboard.kde.org/r/114218/diff/


Testing
-------

ktp-contactlist now show dummy avatars instead of null-ones.
There is no more "Pixmap is a null pixmap" spamming.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/ff982fa8/attachment.html>


More information about the KDE-Telepathy mailing list