Review Request 114218: KPeople: Fixed default avatar location.

Martin Klapetek martin.klapetek at gmail.com
Fri Nov 29 22:37:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114218/#review44850
-----------------------------------------------------------

Ship it!


Ugh, quite an overlook :/ Thanks!

- Martin Klapetek


On Nov. 29, 2013, 10:08 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114218/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 10:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> WIP. I'm not sure if I did it right.
> There is same issue in PersonDetailsView::reload(). I think that it still should be ported to PersonsModel so didn't change it now.
> 
> 
> Diffs
> -----
> 
>   src/personsmodel.cpp 7c238c1 
> 
> Diff: http://git.reviewboard.kde.org/r/114218/diff/
> 
> 
> Testing
> -------
> 
> ktp-contactlist now show dummy avatars instead of null-ones.
> There is no more "Pixmap is a null pixmap" spamming.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/597f288c/attachment-0001.html>


More information about the KDE-Telepathy mailing list