Review Request 114132: Plasmoid Contact: Implemented files transfer by drag'n'drop.

[Alexandr Akulich]

> On Nov. 29, 2013, 5:47 p.m., Martin Klapetek wrote:
> > contact/src/contact-wrapper.h, line 100
> > <http://git.reviewboard.kde.org/r/114132/diff/2/?file=220127#file220127line100>
> >
> >     You don't necessarily have to name variables with their type included, you can do just urls, it can be inferred it's VariantList from its type.
> >     
> >     Makes the API a bit prettier.

It remains from version with two startFileTransfer(). First has variants list and second has urls list argument.
I'm definitely going to fix it.

I'll keep "urlVariant" in foreach (), because "url.toUrl()" in next line would looking strange.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114132/#review44790
-----------------------------------------------------------


On Nov. 26, 2013, 1:52 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114132/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 1:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 288562
>     http://bugs.kde.org/show_bug.cgi?id=288562
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented files transfer by drag'n'drop.
> 
> 
> Diffs
> -----
> 
>   contact/src/declarative/contents/ui/Avatar.qml 4bdeb11 
>   contact/src/contact-wrapper.cpp b516960 
>   contact/src/contact-wrapper.h 778a7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/114132/diff/
> 
> 
> Testing
> -------
> 
> Works almost as expected, but user experience is bad:
> If filetransfer is not available, then drag'n'drop event be catched by plasma, which default reaction is not suitable (it creates new plasmoids instances for each file).
> Would be much better to reject dnd event and indicate that drop isn't accepted, but DropEvent is not QEvent and I have no idea how to set "drop-not-accepted" cursor.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/0a1bea48/attachment.html>