Review Request 114132: Plasmoid Contact: Implemented files transfer by drag'n'drop.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114132/#review44790
-----------------------------------------------------------



contact/src/contact-wrapper.h
<http://git.reviewboard.kde.org/r/114132/#comment32016>

    You don't necessarily have to name variables with their type included, you can do just urls, it can be inferred it's VariantList from its type.
    
    Makes the API a bit prettier.


- Martin Klapetek


On Nov. 26, 2013, 7:52 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114132/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 7:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 288562
>     http://bugs.kde.org/show_bug.cgi?id=288562
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Contact: Implemented files transfer by drag'n'drop.
> 
> 
> Diffs
> -----
> 
>   contact/src/declarative/contents/ui/Avatar.qml 4bdeb11 
>   contact/src/contact-wrapper.cpp b516960 
>   contact/src/contact-wrapper.h 778a7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/114132/diff/
> 
> 
> Testing
> -------
> 
> Works almost as expected, but user experience is bad:
> If filetransfer is not available, then drag'n'drop event be catched by plasma, which default reaction is not suitable (it creates new plasmoids instances for each file).
> Would be much better to reject dnd event and indicate that drop isn't accepted, but DropEvent is not QEvent and I have no idea how to set "drop-not-accepted" cursor.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131129/b7ed8146/attachment-0001.html>