Review Request 114137: Plasmoid Contact: Partially port ContactWrapper to KTp::Contact.

[Alexandr Akulich]

> On Nov. 28, 2013, 3:24 p.m., Martin Klapetek wrote:
> > contact/src/contact-wrapper.cpp, line 287
> > <http://git.reviewboard.kde.org/r/114137/diff/2/?file=220146#file220146line287>
> >
> >     I think this is supposed to be ::qObjectCast
> 
> Alexandr Akulich wrote:
>     I just look around and find it in ktp-contact-runner/src/contactrunner.cpp:266.
>     Should I create review-request for this ^ place as well? It seems like may be I soon will have commit access, so is it better to fix it without RR? (I know well, that RR is natural thing for development process and ask only about this case)
> 
> Martin Klapetek wrote:
>     Nah, two things:
>     
>     1) Old code can be kept as is if it's not causing trouble (yours is new)
>     2) Each change (oneliners included) goes through a review, even if you just pastebin-it and ping someone on irc, always a review, please

1) I'm totally agree to change it here (it just take some time to me) and it's just a question, is it worth another RR (of course old code can be kept, but half of my changes is refactor).
2) Thanks you! Now I understand why David Edmundson does it. I promise, I'll follow it.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114137/#review44658
-----------------------------------------------------------


On Nov. 29, 2013, 12:28 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114137/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 12:28 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Port ContactWrapper capability getters from deprecated methods in Tp::CapabilitiesBase to proper ones in KTp::Contact.
> Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until contacts and avatars cache be implemented.
> 
> 
> Diffs
> -----
> 
>   contact/src/contact-wrapper.h 778a7a0 
>   contact/src/contact-wrapper.cpp b516960 
> 
> Diff: http://git.reviewboard.kde.org/r/114137/diff/
> 
> 
> Testing
> -------
> 
> Capability getters works as expected.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131128/ab19e1f9/attachment-0001.html>