Review Request 114137: Plasmoid Contact: Partially port ContactWrapper to KTp::Contact.
Alexandr Akulich
akulichalexander at gmail.com
Thu Nov 28 18:28:42 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114137/
-----------------------------------------------------------
(Updated Nov. 29, 2013, 12:28 a.m.)
Review request for Telepathy.
Changes
-------
Use SharedPtr::qObjectCast() instead of SharedPtr::dynamicCast().
Repository: ktp-desktop-applets
Description
-------
Port ContactWrapper capability getters from deprecated methods in Tp::CapabilitiesBase to proper ones in KTp::Contact.
Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until contacts and avatars cache be implemented.
Diffs (updated)
-----
contact/src/contact-wrapper.h 778a7a0
contact/src/contact-wrapper.cpp b516960
Diff: http://git.reviewboard.kde.org/r/114137/diff/
Testing
-------
Capability getters works as expected.
Thanks,
Alexandr Akulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131128/a10b1483/attachment.html>
More information about the KDE-Telepathy
mailing list