Review Request 114113: ContactNotify: Show contact avatar instead of presence icon.

[Alexandr Akulich]

> On Nov. 25, 2013, 10:43 p.m., David Edmundson wrote:
> > contactnotify.cpp, line 84
> > <http://git.reviewboard.kde.org/r/114113/diff/1/?file=219722#file219722line84>
> >
> >     don't call a variable icon if it's not an icon, I'll get confused.
> >     
> >

Fixed.


> On Nov. 25, 2013, 10:43 p.m., David Edmundson wrote:
> > contactnotify.cpp, line 93
> > <http://git.reviewboard.kde.org/r/114113/diff/1/?file=219722#file219722line93>
> >
> >     why scale it?
> >     
> >     The old code did because we had to turn the icon into a pixmap.

I don't know if pixmap being showed in original size or not. And if yes, may be it's better to convert it from something like 640x640 to 48x48 before pass it.
Looks like again and again I trying to left something as it been, while better to change it.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114113/#review44442
-----------------------------------------------------------


On Nov. 25, 2013, 10:48 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114113/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 10:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 327208
>     http://bugs.kde.org/show_bug.cgi?id=327208
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> ContactNotify: Notify with contacts avatar instead of presence icon.
> 
> 
> Diffs
> -----
> 
>   contactnotify.h ee79f89 
>   contactnotify.cpp 7b83cfd 
> 
> Diff: http://git.reviewboard.kde.org/r/114113/diff/
> 
> 
> Testing
> -------
> 
> Avatar is showed instead of presence icon.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/fac3b130/attachment.html>