Review Request 114113: ContactNotify: Show contact avatar instead of presence icon.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114113/#review44442
-----------------------------------------------------------



contactnotify.cpp
<http://git.reviewboard.kde.org/r/114113/#comment31769>

    don't call a variable icon if it's not an icon, I'll get confused.
    
    



contactnotify.cpp
<http://git.reviewboard.kde.org/r/114113/#comment31768>

    why scale it?
    
    The old code did because we had to turn the icon into a pixmap.


- David Edmundson


On Nov. 25, 2013, 4:31 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114113/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 4:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 327208
>     http://bugs.kde.org/show_bug.cgi?id=327208
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> ContactNotify: Notify with contacts avatar instead of presence icon.
> 
> 
> Diffs
> -----
> 
>   contactnotify.h ee79f89 
>   contactnotify.cpp 7b83cfd 
> 
> Diff: http://git.reviewboard.kde.org/r/114113/diff/
> 
> 
> Testing
> -------
> 
> Avatar is showed instead of presence icon.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/272eb10f/attachment.html>