Review Request 114109: KTp/Contact: Implemented stream and dbus tubeServicesCapability.

Alexandr Akulich akulichalexander at gmail.com
Mon Nov 25 15:21:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114109/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 9:20 p.m.)


Review request for Telepathy.


Changes
-------

Reimplement getCommonElements() in better way. Thanks David Edmundson.


Repository: ktp-common-internals


Description
-------

KTp/Contact: Implemented stream and dbus tubeServicesCapability.

Fixed ContactTubesRole in Models/ContactsListModel::data().

//Sorry for mixed indention fixes. There is a lot places there it should be done, but I'm not sure that it's ok to create separated RR for each case.


Diffs (updated)
-----

  KTp/contact.h a0a1da8 
  KTp/contact.cpp e94c963 
  KTp/Models/contacts-list-model.cpp dd35f94 

Diff: http://git.reviewboard.kde.org/r/114109/diff/


Testing
-------

Unfortunately I'm not sure that I did it properly, but hope that it's good for review-request.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/07584f6b/attachment.html>


More information about the KDE-Telepathy mailing list