Review Request 114109: KTp/Contact: Implemented stream and dbus tubeServicesCapability.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114109/#review44410
-----------------------------------------------------------

Ship it!



KTp/contact.cpp
<http://git.reviewboard.kde.org/r/114109/#comment31761>

    .contains() is an easy wrapper round .indexOf >= 0
    
    (or in this case you want !.contains())



KTp/contact.cpp
<http://git.reviewboard.kde.org/r/114109/#comment31764>

    Personally I would 
    
    QStringList commonElements;
    Q_FOREACH(const QString &i, list1) {
      if (list2.contains(i)) {
         commonElements << i;
      }
    }
    
    rather than doing a deep copy of list1 only to then remove things. The first time you remove something, it will do a deep copy of the list only to remove other things.
    I would expect this it to be faster as well as being more natural to read.
    
    
    Yours looks like it will work though, so it's up to you.
    
    


- David Edmundson


On Nov. 25, 2013, 1:42 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114109/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 1:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> KTp/Contact: Implemented stream and dbus tubeServicesCapability.
> 
> Fixed ContactTubesRole in Models/ContactsListModel::data().
> 
> //Sorry for mixed indention fixes. There is a lot places there it should be done, but I'm not sure that it's ok to create separated RR for each case.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-list-model.cpp dd35f94 
>   KTp/contact.h a0a1da8 
>   KTp/contact.cpp 64dd49b 
> 
> Diff: http://git.reviewboard.kde.org/r/114109/diff/
> 
> 
> Testing
> -------
> 
> Unfortunately I'm not sure that I did it properly, but hope that it's good for review-request.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131125/cec54183/attachment-0001.html>