Review Request 113840: A couple of features for KTp-Active

[Siddhartha Sahu]

> On Nov. 13, 2013, 9:01 p.m., David Edmundson wrote:
> > application/package/contents/ui/main.qml, line 35
> > <http://git.reviewboard.kde.org/r/113840/diff/1/?file=213926#file213926line35>
> >
> >     If we don't need it, please remove it.

Oh I forgot to ask. Is there a reason for this code? On enabling this, increasing the size of the window increases element's sizes, but decreasing window size does not reflect in the size of the elements, so they extend out of the window area.


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113840/#review43597
-----------------------------------------------------------


On Nov. 13, 2013, 8:10 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113840/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 8:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-active
> 
> 
> Description
> -------
> 
> Changes for:
> 1) Acknowledge messages
> 2) avatar in contact list
> 
> 
> Diffs
> -----
> 
>   application/package/contents/ui/Chat/Chat.qml f99d416 
>   application/package/contents/ui/Contacts/ContactItemDelegate.qml 8487800 
>   application/package/contents/ui/Contacts/ContactsList.qml e537bb7 
>   application/package/contents/ui/main.qml a128885 
> 
> Diff: http://git.reviewboard.kde.org/r/113840/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/4851d221/attachment.html>