Review Request 113840: A couple of features for KTp-Active

David Edmundson david at davidedmundson.co.uk
Wed Nov 13 15:31:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113840/#review43597
-----------------------------------------------------------

Ship it!


Looks good.


application/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/113840/#comment31332>

    If we don't need it, please remove it.


- David Edmundson


On Nov. 13, 2013, 2:40 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113840/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 2:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-active
> 
> 
> Description
> -------
> 
> Changes for:
> 1) Acknowledge messages
> 2) avatar in contact list
> 
> 
> Diffs
> -----
> 
>   application/package/contents/ui/Chat/Chat.qml f99d416 
>   application/package/contents/ui/Contacts/ContactItemDelegate.qml 8487800 
>   application/package/contents/ui/Contacts/ContactsList.qml e537bb7 
>   application/package/contents/ui/main.qml a128885 
> 
> Diff: http://git.reviewboard.kde.org/r/113840/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131113/3dc8eb29/attachment-0001.html>


More information about the KDE-Telepathy mailing list