Review Request 113579: Sort the user list in MUCs properly
Ilya Katsnelson
k0009000 at gmail.com
Sat Nov 2 09:18:50 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113579/
-----------------------------------------------------------
(Updated Nov. 2, 2013, 9:18 a.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy.
Repository: ktp-text-ui
Description
-------
Looks like dynamicSortFilter doesn't resort the data that was in the source model, so the user list isn't actually sorted when you join a room. This patch just forces a sort and then lets dynamicSortFilter handle changes.
Diffs
-----
lib/chat-widget.cpp c2b5a97
Diff: http://git.reviewboard.kde.org/r/113579/diff/
Testing
-------
Tested with a few large chatrooms and some smaller ones, also tested that sorting stays intact when people join/leave.
Thanks,
Ilya Katsnelson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131102/52313a61/attachment.html>
More information about the KDE-Telepathy
mailing list