Review Request 113579: Sort the user list in MUCs properly

Commit Hook null at kde.org
Sat Nov 2 09:18:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113579/#review42826
-----------------------------------------------------------


This review has been submitted with commit 315d9e6109a273022a56880b1e0d7b37345c93ae by David Edmundson on behalf of Ilya Katsnelson to branch kde-telepathy-0.7.

- Commit Hook


On Nov. 2, 2013, 7:36 a.m., Ilya Katsnelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113579/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 7:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Looks like dynamicSortFilter doesn't resort the data that was in the source model, so the user list isn't actually sorted when you join a room. This patch just forces a sort and then lets dynamicSortFilter handle changes.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp c2b5a97 
> 
> Diff: http://git.reviewboard.kde.org/r/113579/diff/
> 
> 
> Testing
> -------
> 
> Tested with a few large chatrooms and some smaller ones, also tested that sorting stays intact when people join/leave.
> 
> 
> Thanks,
> 
> Ilya Katsnelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131102/cfee23a4/attachment.html>


More information about the KDE-Telepathy mailing list