Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid

Commit Hook null at kde.org
Tue Mar 26 20:03:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109699/
-----------------------------------------------------------

(Updated March 26, 2013, 8:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Telepathy.


Description
-------

These are some ideas I got from the last commit, let's see:
* Provide a bigger minimum size, I thought it would never get to the minimum but it does sometimes, so we can better give a bigger minimum (which is still too small for a proper usage).
* Rename preferredWidth/Height -> implicit*. It seems like it's the proper way to call these.
* When the plasmoid is empty, offer an empty preferred (uh implicit) size.


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a 

Diff: http://git.reviewboard.kde.org/r/109699/diff/


Testing
-------

Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130326/e4bbc3d0/attachment.html>


More information about the KDE-Telepathy mailing list