Review Request 109697: Add a status message when date changes

Mon Mar 25 07:58:13 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109697/
-----------------------------------------------------------

Review request for Telepathy.

Description
-------

Add a status message when date changes

BUG: 292041
FIXED-IN: 0.6.0

Make some methods const

Use message sent time instead of received if available

Set time to last content after adding a status message

Set time to the first invalid content message using chat opening time

add{Content,Status}Message should not be Q_SLOTS

AdiumThemeStatusInfo copy constructor should not be explicit

Add a few isXxxx methods AdiumThemeMessageInfo

Diffs
-----

  lib/adium-theme-message-info.h 35ead2368331008deb2b5a8bc303236cd9d92893 
  lib/adium-theme-message-info.cpp 7726fd2c6be4c59bf420a9f1a0d814466a23b1f0 
  lib/adium-theme-status-info.h 1cafbe5c413d1cb0dac43dbd00a081b125ac2261 
  lib/adium-theme-view.h 70618f66ff374c9775391eb0890beb6fddcffd5c 
  lib/adium-theme-view.cpp 361cd6da826f6d684ddd1a145a6c719848745134 
  lib/chat-widget.cpp 612fb87774ec7b6a7a1868e33e91cbab8498f67a 

Diff: http://git.reviewboard.kde.org/r/109697/diff/

Testing
-------

Tested with text ui (screenshot is actually of a the version with the i18n'ed string) and with log viewer (that gets 2 extra messages before "Previous conversation" and "Next conversation", I'm not sure if this is a bug or a feature)

File Attachments
----------------

Log Viewer
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/25/snapshot131.png
Text UI
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/25/snapshot130_1.png

Thanks,

Daniele E. Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130325/d35ae819/attachment.html>