Review Request 109469: Port ktp-kipi-plugin to KTp::Actions

David Edmundson david at davidedmundson.co.uk
Wed Mar 13 18:48:58 UTC 2013



> On March 13, 2013, 6:47 p.m., Martin Klapetek wrote:
> > I think you might want to keep the Tp::PendingComposite and group the operations. Or any particular reason you discarded it?

There are problems if you don't, you're now hiding the progress bar after the first file finishes not the last.
Needs fixing.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109469/#review29147
-----------------------------------------------------------


On March 13, 2013, 6:42 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109469/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 6:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> = summary
> 
> 
> Diffs
> -----
> 
>   kipi-telepathy-dialog.cpp 5de6d92 
> 
> Diff: http://git.reviewboard.kde.org/r/109469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130313/785a31b3/attachment.html>


More information about the KDE-Telepathy mailing list