Review Request 109469: Port ktp-kipi-plugin to KTp::Actions

Martin Klapetek martin.klapetek at gmail.com
Wed Mar 13 18:46:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109469/#review29147
-----------------------------------------------------------


I think you might want to keep the Tp::PendingComposite and group the operations. Or any particular reason you discarded it?


kipi-telepathy-dialog.cpp
<http://git.reviewboard.kde.org/r/109469/#comment21763>

    Coding style - Tp::PendingChannelRequest* -> Tp::PendingChannelRequest *channe....


- Martin Klapetek


On March 13, 2013, 6:42 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109469/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 6:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> = summary
> 
> 
> Diffs
> -----
> 
>   kipi-telepathy-dialog.cpp 5de6d92 
> 
> Diff: http://git.reviewboard.kde.org/r/109469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130313/1e3f2910/attachment.html>


More information about the KDE-Telepathy mailing list