Review Request 109375: Don't add pointless margin to presence applet

David Edmundson david at davidedmundson.co.uk
Sat Mar 9 18:45:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109375/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Don't add pointless margin to presence applet
    
Makes icon appear the same size as other icons in sys-tray
Remove duplicate setMinimumSize (we shouldn't be setting it when not in the panel)


It was added for some important reason at the time which we can't remember but that doesn't seem to be valid now
(a prime example of why you _always_ should comment any workarounds, unlike me here.)


This addresses bug 309852.
    http://bugs.kde.org/show_bug.cgi?id=309852


Diffs
-----

  presence/src/presence-applet.cpp acd6635 

Diff: http://git.reviewboard.kde.org/r/109375/diff/


Testing
-------


File Attachments
----------------

Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/09/before.png
After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/09/after.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130309/d1f4e0ac/attachment.html>


More information about the KDE-Telepathy mailing list