Review Request 109348: A few fixes to text ui

Commit Hook null at kde.org
Fri Mar 8 13:11:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109348/#review28801
-----------------------------------------------------------


This review has been submitted with commit 2ec738f3bca55a3d982c3befa0fbedfed628c483 by Daniele E. Domenichelli to branch master.

- Commit Hook


On March 8, 2013, 9:56 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109348/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 9:56 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> * Fix loading default variant when using main.css
> 
> This fixes, for example, Zelda (OoT)vrs 2 Adium Message Style
> http://www.adiumxtras.com/index.php?a=xtras&xtra_id=3544
> that is displayed correctly from the kcm, but displayed wrong
> when used in the chat ui.
> 
> 
> * Remove extra slash in file name
> 
> This fixes nothing, but it's ugly now... file:////home/xxx
> 
> 
> * Append message classes to messages in SimKete theme
> 
> Allows to handle mention class
> 
> 
> * Handle mention in SimKete theme
> 
> Fix bug 291703
> 
> 
> This addresses bug 291703.
>     http://bugs.kde.org/show_bug.cgi?id=291703
> 
> 
> Diffs
> -----
> 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Incoming/Content.html 46fd21a41ac8ae0542384101a1e3b4de81928f88 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Outgoing/Content.html e46f049507162d41a8909e6dcdbdd31e76810ef9 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Status.html e7b7ecb74dc40f193bf9484f863892eacad001e9 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/main.css 71e47852f199fb1676399ee556bc5773dfba1ff1 
>   lib/adium-theme-view.cpp 929e325d180967979a7ba935fdf282df8583b6a6 
> 
> Diff: http://git.reviewboard.kde.org/r/109348/diff/
> 
> 
> Testing
> -------
> 
> See screenshots
> 
> 
> File Attachments
> ----------------
> 
> Highlighted message in SimKete theme
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/08/snapshot126.png
>  Zelda theme working in ktp-text-ui
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/08/snapshot127.png
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130308/48704d81/attachment.html>


More information about the KDE-Telepathy mailing list