Review Request 109319: Split the display name and the contacts count in the header delegate

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109319/#review28714
-----------------------------------------------------------

Ship it!



abstract-contact-delegate.h
<http://git.reviewboard.kde.org/r/109319/#comment21468>

    [20:10] <mck182> don't mind the header change
    
    Just so people know I saw this :)



abstract-contact-delegate.cpp
<http://git.reviewboard.kde.org/r/109319/#comment21469>

    Fix this.


- David Edmundson


On March 6, 2013, 8:09 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109319/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 8:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> (This patch is originally by drdanz and I want to have this in the beta and he's not around, I did some slight modifications and will commit with his name as author)
> 
> Split the display name and the contacts count in the header delegate
> 
> The contacts count was elided with the display name, and therefore not displayed when the text is elided.
> 
> Also fixes a few small problems:
> 
> * The text was elided in a rect that was for some reason sometime smaller and sometimes bigger than the available area.
> * Add one point for the gray line in the bottom.
> * Play a little bit with spacing, borders and size hints to make it prettier and easier to understand.
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.h 23246d6 
>   abstract-contact-delegate.cpp 8b70eed 
> 
> Diff: http://git.reviewboard.kde.org/r/109319/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/9e71fe04/attachment.html>