Review Request 109319: Split the display name and the contacts count in the header delegate

Martin Klapetek martin.klapetek at gmail.com
Wed Mar 6 20:09:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109319/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

(This patch is originally by drdanz and I want to have this in the beta and he's not around, I did some slight modifications and will commit with his name as author)

Split the display name and the contacts count in the header delegate

The contacts count was elided with the display name, and therefore not displayed when the text is elided.

Also fixes a few small problems:

* The text was elided in a rect that was for some reason sometime smaller and sometimes bigger than the available area.
* Add one point for the gray line in the bottom.
* Play a little bit with spacing, borders and size hints to make it prettier and easier to understand.


Diffs
-----

  abstract-contact-delegate.h 23246d6 
  abstract-contact-delegate.cpp 8b70eed 

Diff: http://git.reviewboard.kde.org/r/109319/diff/


Testing
-------

Yes.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/7fb03edc/attachment-0001.html>


More information about the KDE-Telepathy mailing list