Review Request 109281: Get Plugin Version from CMake

Wed Mar 6 08:28:27 UTC 2013

> On March 6, 2013, 3:32 a.m., David Edmundson wrote:
> > Is this change deliberate?
> > 
> > -X-KTp-PluginInfo-Version=
> > +X-KDE-PluginInfo-Version=
> > 
> > NOTE KTp -> KDE
> >

No, I'm stupid... I'm fixing this in a minute

- Daniele E.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109281/#review28646
-----------------------------------------------------------

On March 5, 2013, 7:17 p.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109281/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 7:17 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Use KTP_TEXT_UI_VERSION for plugin version, and get X-KTp-PluginInfo-Version from CMake
> 
> Since we are not using the version properly, I suggest that we use ktp-text-ui version for all plugins.
> Also by using cmake to set X-KTp-PluginInfo-Version, we can update all of them just by changing one value
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3cef67d54511410fa49135b453d91a6251a8db36 
>   filters/emoticons/CMakeLists.txt 5054e8d1affbc4e52b633059dfad8f824e563923 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop 27968ecef73fe0e4688406850e8e5ef713c8f945 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop.cmake PRE-CREATION 
>   filters/formatting/CMakeLists.txt 1bb818c5e074da7c620387671be220dc4e53cb42 
>   filters/formatting/ktptextui_message_filter_formatting.desktop cccb3817612a16602a3b0e9a0914c0f3873bc01a 
>   filters/formatting/ktptextui_message_filter_formatting.desktop.cmake PRE-CREATION 
>   filters/highlight/CMakeLists.txt 3d6df3ae0ce78bcc2da758261d55e88dcb2d5f4a 
>   filters/highlight/ktptextui_message_filter_highlight.desktop 8ce122e2a980ae0ae30686850e7dfd79a5e49f3c 
>   filters/highlight/ktptextui_message_filter_highlight.desktop.cmake PRE-CREATION 
>   filters/images/CMakeLists.txt 33bdbc9f64beeea9d1b2ac13f5c2d1d4f9d01b1f 
>   filters/images/ktptextui_message_filter_images.desktop 1282258dc79aad459802ae392315db9609471aff 
>   filters/images/ktptextui_message_filter_images.desktop.cmake PRE-CREATION 
>   filters/searchexpansion/CMakeLists.txt 2b6c95d9505e4ebc87c0a96b5ca95766ec0ec5d0 
>   filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop 0597f14191cac2c6a54ebfb109b88435a85c7ccc 
>   filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop.cmake PRE-CREATION 
>   filters/texttospeech/CMakeLists.txt 8f2569670377942bfa37f3c4777864f5c9fcc100 
>   filters/texttospeech/ktptextui_message_filter_tts.desktop ffb8d93b888ad6b008c726b15a130e9537ab34d8 
>   filters/texttospeech/ktptextui_message_filter_tts.desktop.cmake PRE-CREATION 
>   filters/youtube/CMakeLists.txt 3d4eb5ae2959ea984898e2e9f0279821bc27d940 
>   filters/youtube/ktptextui_message_filter_youtube.desktop 8a2572f41bcbf475b8fe379bf80b4c2cc494ac12 
>   filters/youtube/ktptextui_message_filter_youtube.desktop.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/683b7e4d/attachment-0001.html>